Fail to construct preload hamt shards when traversal fails #55
Conversation
| func (n UnixFSHAMTShard) Length() int64 { | ||
| len, err := n.length() | ||
| if err != nil { | ||
| return 0 |
There was a problem hiding this comment.
Don't feel strongly about the number chosen here, as mentioned in ipld/go-ipld-prime#531 we're really in a rough spot here.
This is a behavior change from previously, but if you don't want to return -1 or a different negative number then 0 is probably more reasonable than what we were doing here before.
There was a problem hiding this comment.
i'm happy to take suggestions - do you think it makes sense to do -2 or similar in this case?
There was a problem hiding this comment.
I'd prefer 0 until we have some kind of agreement on the best way to deal with ipld/go-ipld-prime#531, otherwise this is an outlier.
|
We could memoize the |
|
given that 0 length leaves us unlikely to get the memoized error, i think i'm going to not add the complexity for that. |
Fix #54