-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: download as CAR via the context menu #1837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg @olizilla @mikeal @alanshaw
Would appreciate some opinionated bikeshed around labels related to DAG export/import in UI (webui/desktop).
Does the above screenshot look sensible?
Mainly, I want this to be consistent with messaging we have in dev docs in other places (are we using "DAG export" or "CAR download" etc)?
I think this is probably OK, we've put IPFS' "export" inside the "dag" subsection and it's technically correct that it's exporting an entire DAG starting from a root. We have other place that are front-loading "CAR", like web3.storage which has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's park this until we have a PR with import (#1838) as noted in #1798 (comment)
8135d53
to
11089b7
Compare
6266f9b
to
a52f188
Compare
@lidel I rebased and made the necessary updates to use the new gateway URLs and the nomenclature. Notes:
Question:
|
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
a52f188
to
5eaeb4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is unblocked because go-ipfs 0.13 supports ?format=car
(release notes) and we now have PR with gateway specs at ipfs/specs#283
Needs small unicode fix below, but I'll apply it shortly.
Unsure why CI deps install fail, probably the usual NPM rot.
Will regenerate package-lock and see if that helps.
92dd1c6
to
96f678e
Compare
96f678e
to
f31a2a3
Compare
Partially addresses #1798.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com