Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove web ui version and keep revision #2000

Merged
merged 3 commits into from
Aug 9, 2022
Merged

fix: remove web ui version and keep revision #2000

merged 3 commits into from
Aug 9, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 9, 2022

Addresses #1984 for now by removing the Web UI version. However, I think @SgtPooki should still take a look at it in order to have the current revision.

@hacdias hacdias requested a review from lidel August 9, 2022 07:37
@hacdias hacdias temporarily deployed to Deploy August 9, 2022 07:41 Inactive
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind also replacing version with GIT_REV on Status screen?

2022-08-09_13-54

@hacdias hacdias requested a review from lidel August 9, 2022 12:17
@hacdias
Copy link
Member Author

hacdias commented Aug 9, 2022

Done @lidel

@hacdias hacdias temporarily deployed to Deploy August 9, 2022 12:21 Inactive
no need for it to be clicable (kubo version is not)
nor for it to say "revision" (it is UI, and not kubo or desktop
revision)
@lidel lidel temporarily deployed to Deploy August 9, 2022 17:11 Inactive
@lidel lidel merged commit 42ed78d into main Aug 9, 2022
@lidel lidel deleted the fix/1984 branch August 9, 2022 18:52
ipfs-gui-bot pushed a commit that referenced this pull request Sep 9, 2022
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09)

 CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm`

 ---

### Features

* IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939))
* ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632))

### Bug Fixes

* **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460))
* korean detection ([#2005](#2005)) ([362dab8](362dab8))
* Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988))
* nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b))
* remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d))
* resolve issues with automated releases  ([#1974](#1974)) ([9a7cfad](9a7cfad))

### Trivial Changes

* add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8))
* **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260))
* pull transifex translations ([#1996](#1996)) ([0de4267](0de4267))
* Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15))
* **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d))
* **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822))
* Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d))
* update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants