Skip to content

Feat/better fetch #126

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from
Closed

Feat/better fetch #126

wants to merge 2 commits into from

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented May 27, 2021

No description provided.

@jacobheun jacobheun added the status/blocked Unable to be worked further until needs are met label Jun 14, 2021
@BigLep
Copy link

BigLep commented Jun 14, 2021

We're on pause on here until we see if @achingbrain's merge into node-fetch get accepted.

@achingbrain
Copy link
Member

Taking on the long term maintenance burden of a node-fetch fork worries me a little, despite node-fetch being a little rough around the edges.

This is the pending PR: node-fetch/node-fetch#1172 - if it doesn't get merged maybe @web-std/fetch becomes a viable alternative but I think we should exhaust all other possibilities first.

@Gozala
Copy link
Contributor Author

Gozala commented Jun 14, 2021

Let's reopen if we choose to do it in the future. For what it's worth we're using @web-std/fetch in bunch of places in the nft.storage.

@Gozala Gozala closed this Jun 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants