Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Broken terminal output with API and Gateway on ipv6 #1853

Closed
lidel opened this issue Jan 29, 2019 · 1 comment
Closed

Broken terminal output with API and Gateway on ipv6 #1853

lidel opened this issue Jan 29, 2019 · 1 comment
Assignees
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Jan 29, 2019

Setting API and Gateway to listen on /ip6/ multiaddr..

   "Addresses": {                                                                                                                                                                                                                                
     "Swarm": [                                                                                                                                                                                                                                  
       "/ip4/0.0.0.0/tcp/4002",                                                                                                                                                                                                                  
       "/ip4/127.0.0.1/tcp/4003/ws"                                                                                                                                                                                                              
     ],                                                                                                                                                                                                                                          
     "API": "/ip6/::1/tcp/5002",                                                                                                                                                                                                                 
     "Gateway": "/ip6/::1/tcp/9090"                                                                                                                                                                                                              
   }, 

works 👍

..but the terminal output is broken:

$ jsipfs daemon                                                                                                                                                                                                                           
[...]
API listening on /ip4//tcp/
Gateway (read only) listening on /ip4//tcp/
Web UI available at http://::1:5002/webui
Daemon is ready

Expected output:

API listening on /ip6/::1/tcp/5002
Gateway (read only) listening on /ip6/::1/tcp/9090
Web UI available at http://[::1]:5002/webui

ps. some quick notes from brief eyeballing:

  • apiMultiaddr is set here but does not seem to be used for anything
  • uri-to-multiaddr should be a good replacement for uriToMultiaddr in src/http/index.js
  • it may be worth thinking if we want to fix it now, or after hapi situation is resolved (needs to be upgraded or migrated away to something else)
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up help wanted Seeking public contribution on this issue labels Jan 30, 2019
@alanshaw
Copy link
Member

Probably worth waiting for #1844 to be merged first, but this seems like a simple fix - @lidel would you be willing to submit a PR?

lidel added a commit to lidel/js-ipfs that referenced this issue Jan 30, 2019
Fixes ipfs#1853

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@ghost ghost assigned lidel Jan 30, 2019
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 30, 2019
lidel added a commit that referenced this issue Feb 8, 2019
Fixes #1853

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@ghost ghost removed the status/in-progress In progress label Feb 11, 2019
alanshaw pushed a commit that referenced this issue Feb 11, 2019
Fixes #1853 

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants