Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] feat: use new IPLD API #1848

Closed
wants to merge 1 commit into from
Closed

[WIP] feat: use new IPLD API #1848

wants to merge 1 commit into from

Conversation

vmx
Copy link
Member

@vmx vmx commented Jan 28, 2019

This is part of the Awesome Endeavour: Async Iterators:
#1670

Currently it checks out IPLD directly from a branch. The reason is that I'd like to get approval from all users of the new API first, so that I can still make changes while keeping the history clean.

I probably needs those PRs to be merged first:

@ghost ghost assigned vmx Jan 28, 2019
@ghost ghost added the status/in-progress In progress label Jan 28, 2019
@vmx vmx requested a review from alanshaw January 28, 2019 11:22
@alanshaw alanshaw changed the title feat: use new IPLD API [WIP] feat: use new IPLD API Feb 6, 2019
@@ -27,34 +27,34 @@ const mfsPreload = require('./mfs-preload')

// All known (non-default) IPLD formats
const IpldFormats = {
get 'bitcoin-block' () {
get [multicodec.BITCOIN_BOCK] () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: BITCOIN_BLOCK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This is part of the Awesome Endeavour: Async Iterators:
#1670
@alanshaw
Copy link
Member

@vmx FYI I've rebased and resolved the conflict

@alanshaw alanshaw mentioned this pull request May 13, 2019
13 tasks
@achingbrain
Copy link
Member

Superseded by #2068

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants