ipfs id <id> fails

[jbenet]

> ipfs daemon
> ipfs id <some peer's id>
Error: peer publickey not populated on offline runs,
please run the daemon to use ipfs id!

There's some other problem. I can ipfs id <mars id> just fine, but fails when i try other peers. (it's not connecting correctly :( )

[whyrusleeping]

odd... i would check to see if the FindPeer rpc is succeeding or not

[jbenet]

output:

21:30:34.937 DEBUG commands/h: Incoming API request: /api/v0/id?arg=QmbqWJCWqNxC3rZUJLxTNZUrGTZHC6SypaCXgXQXPbbtRA&encoding=json handler.go:37
21:30:34.937 DEBUG        dht: Run query with 1 peers. query.go:110
21:30:34.937 DEBUG        dht: adding peer to query: [Peer QmaCpDMGvV2B]
 query.go:184
21:30:34.937 DEBUG        dht: spawning worker for: [Peer QmaCpDMGvV2B]
 query.go:208
21:30:34.937 DEBUG        dht: spawned worker for: [Peer QmaCpDMGvV2B] query.go:215
21:30:34.937 DEBUG        dht: running worker for: [Peer QmaCpDMGvV2B] query.go:226
21:30:34.938 DEBUG      swarm: [Peer QmRUCMuXxPTj] sent message to [Peer QmaCpDMGvV2B] (3) conn.go:202
21:30:34.938  INFO       conn: [Peer QmRUCMuXxPTj] (/ip4/192.168.43.142/tcp/54956) <-- secureConn --> (/ip4/104.131.131.82/tcp/4001) [Peer QmaCpDMGvV2B] sending (3) multiconn.go:162
21:30:36.178  INFO       conn: [Peer QmRUCMuXxPTj] (/ip4/192.168.43.142/tcp/54956) <-- secureConn --> (/ip4/104.131.131.82/tcp/4001) [Peer QmaCpDMGvV2B] received (3) multiconn.go:208
21:30:36.178 DEBUG      swarm: [Peer QmRUCMuXxPTj] received message from [Peer QmaCpDMGvV2B] (3) conn.go:238
21:30:36.179 WARNI       conn: Releasing buffer! (cap,size = 1048576, 298) conn.go:45
21:30:36.179 DEBUG        dht: SUCCESS worker for: [Peer QmaCpDMGvV2B]%!(EXTRA *dht.dhtQueryResult=&{[] 0xc208434460 [] [] true}) query.go:257
21:30:36.179 DEBUG        dht: completing worker for: [Peer QmaCpDMGvV2B] query.go:231
21:30:36.179 DEBUG        dht: FindPeer QmbqWJCWqNxC3rZUJLxTNZUrGTZHC6SypaCXgXQXPbbtRA true routing.go:254

[whyrusleeping]

Ill tackle this once bithack is finished.

[whyrusleeping]

Ah, found the issue. I made the assumption that pubkey == nil means youre offline. This isnt true for findpeer RPCs where we arent connected to someone (and havent done a handshake to get their public key)

[whyrusleeping]

resolved in 2ec2c85