Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(migrations): use dweb.link instead of ipfs.io #10133

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 20, 2023

This is a quick fix which replaces ipfs.io with dweb.link to allow users who's ISP is blocking ipfs.io gateway (like COX.NET here) to still benefit from HTTPS mirror.

I've confirmed this works (v0.18.0→v0.22.0), because golang's http client follows redirect to subdomain gateway:

Run migrations now? [y/N] y
[...]
Downloading migration: fs-repo-13-to-14...
Fetching with HTTP: "https://dweb.link/ipfs/QmYerugGRCZWA8yQMKDsd9daEVXUR3C5nuw3VXuX1mggHa/fs-repo-13-to-14/versions"
Fetching with HTTP: "https://dweb.link/ipfs/QmYerugGRCZWA8yQMKDsd9daEVXUR3C5nuw3VXuX1mggHa/fs-repo-13-to-14/v1.0.0/fs-repo-13-to-14_v1.0.0_linux-amd64.tar.gz"
Downloaded and unpacked migration: /tmp/migrations2100767190/fs-repo-13-to-14 (v1.0.0)

(Long term we want to have multiple names once #9159 is implemented, but for now this is an easy 1-line fix)

cc https://github.com/protocol/bifrost-infra/issues/2765 (internal ipfs.io notes)

this is a quick fix to allow users who's ISP is blocking ipfs.io
to benefit from HTTPS mirror
@lidel lidel requested a review from a team as a code owner September 20, 2023 17:13
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Sep 20, 2023
@lidel lidel mentioned this pull request Sep 20, 2023
14 tasks
@lidel lidel requested review from hacdias and Jorropo September 20, 2023 17:25
@SgtPooki
Copy link
Member

should we have multiple fallbacks though? and what's the reason we're not defaulting to IPFS first?

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would love for us to be using ipfs.io AND dweb.link. I understand there seems to be more context behind why we're not doing so now.

@lidel
Copy link
Member Author

lidel commented Sep 21, 2023

@SgtPooki yes, once we have #9159 we will implement a list that will include multiple hostnames to try.

@lidel lidel merged commit f46bf77 into master Sep 21, 2023
@lidel lidel deleted the fix/fetch-migrations-url branch September 21, 2023 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants