Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(autotls): store certificates at the location from the repo path #10566

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(autotls): store certificates at the location from the repo path #10566

merged 2 commits into from
Oct 30, 2024

Conversation

aschmahmann
Copy link
Contributor

This slipped through the crack, but it's basically the same fix as #10492. We meant to get this in between when that PR landed and the initial AutoTLS one did but forgot. Could use a test to make sure it's correct before merging so we don't have to test it out with multiple repo paths manually.

@aschmahmann aschmahmann requested a review from a team as a code owner October 30, 2024 21:41
@lidel lidel mentioned this pull request Oct 30, 2024
Closed
28 tasks
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Oct 30, 2024
lidel
lidel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Tested with pre-existing repo that had autotls and it picked up certs ok.
Once CI finishes, I'll merge+ cherry-pick to #10563

@lidel lidel merged commit 1ca0ae0 into master Oct 30, 2024
14 checks passed
@lidel lidel deleted the fix/autotls-certstore branch October 30, 2024 22:23
lidel pushed a commit that referenced this pull request Oct 30, 2024
@aschmahmann @lidel
fix(autotls): store certificates at the location from the repo path (#…
84345af 
…10566)

* fix(autotls): store certificates at the location from the repo path
* docs(autotls): cert storale and other caveats

---------

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit 1ca0ae0)
@lidel lidel mentioned this pull request Oct 31, 2024
Open
19 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschmahmann @lidel