fix a few race conditions in mocknet #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
Theres still a race around there, but its because logrus isnt threadsafe (or we're not using it right). Worst case on that one is just that we get a weird looking log entry. I'm gonna punt on fixing it for now. |
whyrusleeping
added
kind/bug
jbenet
added a commit
that referenced
this pull request
Oct 20, 2015
fix a few race conditions in mocknet
if it's not a panic, fine |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSA: if you think you need a RWMutex, you probably dont, if you really think you do, double check that your data is safe to read concurrently. (go's maps are not)
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com