Out of range in ipfs add #2506
Closed
Out of range in ipfs add #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,7 +178,7 @@ func (adder *Adder) Finalize() (*dag.Node, error) { | |||
| } | |||
|
|
|||
| var name string | |||
| if !adder.Wrap { | |||
| if !adder.Wrap && len(root.Links) == 1 { | |||
There was a problem hiding this comment.
This is the fix.
|
Good catch, Do you think you could add a sharness test for this somewhere? maybe in |
|
Will do |
|
@MichaelMure the codepath youre toching in the PR has changed. Can you rerun your repro and see if this issue still occurs on master? |
License: MIT Signed-off-by: Michael Muré <batolettre@gmail.com>
License: MIT Signed-off-by: Michael Muré <batolettre@gmail.com>
License: MIT Signed-off-by: Michael Muré <batolettre@gmail.com>
MichaelMure
force-pushed
the
add_out_of_range
branch
from
aea496d to
954c968
Compare
whyrusleeping
added
need_tests
need/author-input
|
I don't think the bugfix here is relevant any longer, but the documentation would be nice. |
|
Closing due to inactivity, please reopen as needed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I triggered an out of range in coreunix/add.go when adding a file through the API (I accidentally made a POST query without an actual file content).
Fixed it and documented/cleaned the code in the process.