-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[rfc] bash completion improvements #2529
Conversation
…nary License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
N.B., Github wraps commit messages before 75 colzzz |
compopt -o nospace | ||
;; | ||
cat|recursive|direct|indirect|all) | ||
reply="$(__ipfs_pin_list)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is going to be painfully slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @chriscool and @lgierth might have some opinions here |
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
Can we kill GitCop? @chriscool what is happening here. |
It looks like the commit has no "Signed-off-by: .* <.*>" line, only a "License: MIT" line (see dc80a3d). |
Ack---nothing gets past this cop.
While you guys are here, have you tried this out yet?
|
License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
{ | ||
_ipfs_help_only | ||
__ipfs_pin_list() { | ||
ipfs refs local 2>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be careful about using this, its not a fast call (especially when you have gigabytes of content)
I havent tried this out yet since I don't use bash (fish shell ftw). If some bash users could give this a shot and report back, that would be very helpful |
I looked at this recently and it's now completely broken. Will checkout the other PR. |
This completion script is a little smarter than the current one. Some selling points are that it:
Let me know if it works.