Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[rfc] bash completion improvements #2529

Closed
wants to merge 2 commits into from
Closed

[rfc] bash completion improvements #2529

wants to merge 2 commits into from

Conversation

atomgardner
Copy link
Contributor

This completion script is a little smarter than the current one. Some selling points are that it:

  • generates matches on the fly
  • supports file/peer/pin completion
  • is probably easier to hack on

Let me know if it works.

…nary

License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
@atomgardner
Copy link
Contributor Author

N.B., Github wraps commit messages before 75 colzzz

compopt -o nospace
;;
cat|recursive|direct|indirect|all)
reply="$(__ipfs_pin_list)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be painfully slow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyrusleeping
Copy link
Member

I think @chriscool and @lgierth might have some opinions here

@GitCop
Copy link

GitCop commented Apr 6, 2016

There were the following issues with your Pull Request

  • Commit: dc80a3d
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@RichardLitt
Copy link
Member

Can we kill GitCop? @chriscool what is happening here.

@chriscool
Copy link
Contributor

It looks like the commit has no "Signed-off-by: .* <.*>" line, only a "License: MIT" line (see dc80a3d).

@atomgardner
Copy link
Contributor Author

atomgardner commented Apr 7, 2016 via email

License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
{
_ipfs_help_only
__ipfs_pin_list() {
ipfs refs local 2>/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be careful about using this, its not a fast call (especially when you have gigabytes of content)

@whyrusleeping
Copy link
Member

I havent tried this out yet since I don't use bash (fish shell ftw). If some bash users could give this a shot and report back, that would be very helpful

@whyrusleeping whyrusleeping added the need/review Needs a review label May 14, 2016
@atomgardner
Copy link
Contributor Author

I looked at this recently and it's now completely broken. Will checkout the other PR.

@atomgardner atomgardner deleted the completion branch June 16, 2016 03:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants