make warnings on no bootstrap peers less noisy #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
schomatis
approved these changes
Sep 14, 2018
core/bootstrap.go
Outdated
| @@ -141,6 +138,11 @@ func bootstrapRound(ctx context.Context, host host.Host, cfg BootstrapConfig) er | |||
| // if connected to all bootstrap peer candidates, exit | |||
| if len(notConnected) < 1 { | |||
| log.Debugf("%s no more bootstrap peers to create %d connections", id, numToDial) | |||
| if len(peers) == 0 { | |||
| // We're *need* to bootstrap but we have no bootstrap | |||
There was a problem hiding this comment.
nit: "We're need" -> "We need"
We only need to warn the user if we *can't* connect to the network. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/less-noisy-boostrap-warning
branch
from
2a47656 to
224bc0d
Compare
magik6k
approved these changes
Sep 19, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to warn the user if we can't connect to the network.