feat(command): merge file ls and ls #5500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
2 times, most recently
from
a254b9e to
17a3f9a
Compare
kevina
reviewed
Sep 21, 2018
core/commands/ls.go
Outdated
| > ipfs file ls QmW2WQi7j6c7UgJTarActp7tDNikE4B2qXtFCfLPdsgaTQ | ||
| cat.jpg | ||
| > ipfs file ls /ipfs/QmW2WQi7j6c7UgJTarActp7tDNikE4B2qXtFCfLPdsgaTQ | ||
| cat.jpg |
There was a problem hiding this comment.
I think this information is overkill. Syntax for paths should be documented somewhere else.
core/commands/ls.go
Outdated
| @@ -26,7 +26,7 @@ import ( | |||
| type LsLink struct { | |||
| Name, Hash string | |||
| Size uint64 | |||
| Type unixfspb.Data_DataType | |||
There was a problem hiding this comment.
I am not sure I like the idea of replacing an enum type with a string....
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
5 times, most recently
from
d014e21 to
1648961
Compare
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
from
1648961 to
34ebe30
Compare
overbool
changed the title
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
2 times, most recently
from
1e00655 to
3ea54c3
Compare
|
We have to maintain API compatibilities so we can only add fields. |
@Kubuxu Which modification do you mean? |
|
As an example the switch from enum to string. |
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
from
3ea54c3 to
d4c1d19
Compare
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
from
d4c1d19 to
dc9456f
Compare
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
overbool
force-pushed
the
fix/merge-file-ls-and-ls
branch
from
cf54426 to
c36b563
Compare
|
@Kubuxu I had changed it as your suggestion and updated the test. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com
Fixes: #5497 and #5502