refactor(config): remove Swarm.ConnMgr defaults #8913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
schomatis
force-pushed
the
schomatis/chore/config/optional-types-for-Swarm.ConnMgr
branch
from
0b7809a to
c1c92db
Compare
lidel
force-pushed
the
schomatis/chore/config/optional-types-for-Swarm.ConnMgr
branch
2 times, most recently
from
ec4b83f to
22ece13
Compare
lidel
changed the title
lidel
force-pushed
the
schomatis/chore/config/optional-types-for-Swarm.ConnMgr
branch
from
22ece13 to
a47c4a4
Compare
lidel
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
I've rebased this and updated docs. Lgtm.
- This PR enables us to change implicit defaults without having to modify user config.
- One-time config migration may be useful, to remove historical defaults from user configs, but that would be a separate PR, where we also lower the defaults (no need to keep hundreds of connections around anymore, its a relict from the time DHT was not performing well).
Let's park this until next week – if there is 0.17.0-rc2, we would like to include this. If not, it can wait until 0.18.
Closed
This moves defaults to Kubo code, cleaning up config. If value is in config, we assume it is an explicit choice made by user. Makes migrations easier.
lidel
force-pushed
the
schomatis/chore/config/optional-types-for-Swarm.ConnMgr
branch
from
a47c4a4 to
d2f3fd9
Compare
lidel
deleted the
schomatis/chore/config/optional-types-for-Swarm.ConnMgr
branch
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8845.
Sorry for the delay. I was digging around config's
Optionalstructs implementation to look for a cleaner approach but that shouldn't be blocking this (it can be addressed later in a separate issue).