Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Avoid unknown fields on config #9438

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented Nov 30, 2022

This will reduce headaches when adding wrong fields to the config.

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

@ajnavarro ajnavarro changed the title Avoid unknown fields on config fix: Avoid unknown fields on config Nov 30, 2022
@ajnavarro ajnavarro self-assigned this Dec 1, 2022
@BigLep
Copy link
Contributor

BigLep commented Dec 1, 2022

2022-12-01 standup conversation:

  • Agreed on strict mode by default
  • Provide environment variable to bypass validation
  • We want to keep strict mode as possible for sharness
  • We should have a test that validates that strict mode does raise an error when you use an invalid strict

This will reduce headaches when adding the wrong fields to the config.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the fix/avoid-wrong-fields-on-config branch from d476c5d to 0bff00e Compare December 2, 2022 16:54
@BigLep BigLep mentioned this pull request Dec 7, 2022
@ajnavarro ajnavarro removed their assignment Feb 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Status: 🥞 Todo
Development

Successfully merging this pull request may close these issues.

2 participants