Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Increase MaxMemory param to use 1/4 of total memory. #9446

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented Dec 2, 2022

Per discussion here: #9443 (comment)
We are going to set the default max memory to 1/2 of the total memory instead of 1/8 to improve the default total inbound connections number, trying to avoid CM errors.

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

Previously it was using 1/8 of the total memory.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro requested a review from BigLep December 2, 2022 11:24
@ajnavarro ajnavarro changed the title Increase MaxMemory param to use half of total memory. Fix: Increase MaxMemory param to use half of total memory. Dec 2, 2022
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajnavarro : looks good to me. I think it's also useful to give context in the PR where this is coming from: #9443 (comment)

This should also be added to #9442

@ajnavarro
Copy link
Member Author

@BigLep added a comment on the PR description.

@ajnavarro ajnavarro self-assigned this Dec 5, 2022
@BigLep
Copy link
Contributor

BigLep commented Dec 6, 2022

Per 2022-12-06 maintainer conversation, we're going to go from half to a quarter of system memory.

Co-authored-by: Steve Loeppky <biglep@protocol.ai>
@ajnavarro ajnavarro enabled auto-merge (rebase) December 7, 2022 09:19
@ajnavarro ajnavarro changed the title Fix: Increase MaxMemory param to use half of total memory. Fix: Increase MaxMemory param to use 1/4 of total memory. Dec 7, 2022
@ajnavarro ajnavarro merged commit 7a8639e into master Dec 7, 2022
@hacdias hacdias deleted the fix/increase-default-max-memory-on-rm branch May 9, 2023 11:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants