Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

inline data #69

Merged
merged 3 commits into from
Dec 18, 2023
Merged

inline data #69

merged 3 commits into from
Dec 18, 2023

Conversation

adeel-usmani
Copy link
Contributor

No description provided.

@adeel-usmani adeel-usmani changed the title initial push inline data Dec 8, 2023
@adeel-usmani
Copy link
Contributor Author

Brother @UmanShahzad can you please review this?

Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're gonna wanna do a backwards-incompat change and just accept an in-memory map from the user. See some of the other SDKs for example. Forget about accepting a 'file' now.

src/IPinfo.php Outdated Show resolved Hide resolved
@UmanShahzad UmanShahzad merged commit e1e1823 into ipinfo:master Dec 18, 2023
3 checks passed
@jfiel
Copy link

jfiel commented Nov 22, 2024

Hi Team,

You can do whatever you want but you should know that moving the constants to a file that is required instead of putting them in a class or trait caused our application which uses PHP preload to error during runtime.

The error at runtime was "Undefined constant 'ipinfo\ipinfo\COUNTRIES'".

I had to write an exclusion to prevent ipinfo\ipinfo\IPinfo from being compiled with my application in preload.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants