Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename Callback to a more specific name: MultihashLister #194

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

masih
Copy link
Member

@masih masih commented Mar 10, 2022

Use a more specific term to descibe the hook used by the index provider
engine to list multihashes associated to a context ID:
MultihashLister, and update docs as needed.

Use a more specific term to descibe the hook used by the index provider
engine to list multihashes associated to a context ID:
`MultihashLister`, and update docs as needed.
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #194 (f72014c) into main (822974e) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   38.17%   38.17%           
=======================================
  Files          49       49           
  Lines        3526     3526           
=======================================
  Hits         1346     1346           
  Misses       1929     1929           
  Partials      251      251           
Impacted Files Coverage Δ
cmd/provider/daemon.go 0.00% <ø> (ø)
engine/linksystem.go 59.25% <33.33%> (ø)
engine/engine.go 61.31% <100.00%> (ø)
mock/interface.go 33.33% <100.00%> (ø)
supplier/car_supplier.go 55.76% <100.00%> (ø)

@masih masih merged commit da14b55 into main Mar 10, 2022
@masih masih deleted the masih/refactor-callback-rename branch March 10, 2022 17:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants