Read schema type hint from sync request #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Head the schema type hint from the IPNI sync request header, and if provided, compare it against the type of data retrieved.
willscott
reviewed
Sep 17, 2024
Comment on lines
+67
to
+81
| if cidSchemaType != "" && cidSchemaType != ipnisync.CidSchemaAdvertisement { | ||
| log.Errorf("Retrieved advertisement when asked for %s", cidSchemaType) | ||
| return nil, errors.New("data does not match requested type") | ||
| } | ||
| log.Debugw("Retrieved advertisement from datastore", "cid", c, "size", len(val)) | ||
| return bytes.NewBuffer(val), nil | ||
| } | ||
| log.Debugw("Retrieved non-advertisement object from datastore", "cid", c, "size", len(val)) | ||
| } | ||
|
|
||
| if cidSchemaType != "" && cidSchemaType != ipnisync.CidSchemaEntryChunk { | ||
| log.Errorf("Asked for %s when expecting %s", cidSchemaType, ipnisync.CidSchemaEntryChunk) | ||
| return nil, errors.New("requested unexpected data type") | ||
| } | ||
|
|
There was a problem hiding this comment.
lets log these but not return an error?
if we got the right data that matches the cid, we should continue, not error
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the schema type hint from the IPNI sync request header, and if provided, compare it against the type of data retrieved.