Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update to student name, CPF and term number error messages #151

Merged
merged 46 commits into from
Feb 2, 2023
Merged

fix: update to student name, CPF and term number error messages #151

merged 46 commits into from
Feb 2, 2023

Conversation

ByteCarlos
Copy link
Contributor

No description provided.

ruancelisantos and others added 30 commits October 25, 2022 09:29
@ruancelisantos
Merge pull request #131 from ipti/dev
91084eb 
V2.13.0
@ByteCarlos
Student search by inep_id
4461224
@ByteCarlos
Changed next button to save in student edit
04c7b56 
Pending: In StudentController on line 265 there is an error in the condition (commented for testing purposes) that was preventing the student registration update
@ByteCarlos
Fixed error
853b341 
In StudentController at line 265 and line 177 there is an error in the condition that was preventing the updating and creation of the student's record
@ByteCarlos
Class module reports with Inep ID information added
39dc7b1
@ByteCarlos
Reports of students participating in Bolsa Família and students with …
c58a054 
…pending documents with Inep ID added
@ByteCarlos
Added deactivate user function
d27b7e7
@ByteCarlos
Console.log remove
b28ed76
@ByteCarlos
feat: Active and disable User
d6313d0 
/app/views/activeDisableUser.php
/app/controllers/AdminController.php
@ByteCarlos
feature: Blocking mechanism for student duplicity; (CPF -> Certificat…
e895aaf 
…e -> Name) ✨
@ByteCarlos
feature: Error typing existing name in add student form ✨
5788481
@ByteCarlos
feature: Error typing the existing cpf in the student addition form ✨
fbdb513
@ByteCarlos
fix: added new name validation function for mother and father name fi…
31f3a88 
…elds 🚑
@ByteCarlos
feature: Error when typing the existing certificate number in the stu…
1db0822 
…dent inclusion form ✨
@ByteCarlos
Merge branch 'dev' into ticarlosh
16ded67
@ByteCarlos
Bugfix: disable and enable pending buttons on icons 🐛
ec4b3ce
@ByteCarlos
Bugfix: missing new student name validation in another js file 🐛
3ebe68c
@ByteCarlos
feature: display record similar to the student name entered in the st…
c3c6fa9 
…udent registration ✨
@ByteCarlos
bug fix: re-enabled next button function and create/save button only …
6268f27 
…appears on last registration page 🐛
@ByteCarlos
Update instance.php
59aef72
@ByteCarlos
fix: Merge updates
103112c
@ByteCarlos
Update instance.php
d19800a
@ByteCarlos
Update main.php
58723c0
@ByteCarlos
feature: Able to change values ​​from previous years with the same lo…
a33f31c 
…gin without having to access the year ✨
@ByteCarlos
Update global.js
b356293
@ByteCarlos
Update StudentByClassroomReport.php
93fda48
@ByteCarlos
Removed a modified file from pull request
9193917
@ByteCarlos
Removed a modified file from pull request
f971b27
@ByteCarlos
refactor: added toggle and toggle icons 🎨
9846b0d
@ByteCarlos
fix: Form errors now prevent student registration 🐛
cd4e62f
@ByteCarlos ByteCarlos temporarily deployed to QA January 30, 2023 15:07 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 30, 2023 15:07 — with GitHub Actions Inactive
ByteCarlos
ByteCarlos commented Jan 30, 2023
View reviewed changes
Copy link
Contributor Author

@ByteCarlos ByteCarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending: standardize error messages on the add student form

@ByteCarlos
fix: corrected cpf error now it is in the right field and the new mod…
b53d710 
…el certificate field now has the correct messages
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 13:28 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 13:28 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 13:46 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 13:46 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 14:13 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 14:13 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 14:36 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA January 31, 2023 14:37 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA February 2, 2023 12:00 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA February 2, 2023 12:00 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 52 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@igorgoncalves igorgoncalves merged commit 2fb9ffb into dev Feb 2, 2023
@igorgoncalves igorgoncalves mentioned this pull request Aug 1, 2023
Merged
@igorgoncalves igorgoncalves mentioned this pull request Oct 31, 2023
Merged
@igorgoncalves igorgoncalves deleted the ticarlosh branch December 6, 2023 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ByteCarlos @igorgoncalves @ruancelisantos