Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: form fixes in user edit #166

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: form fixes in user edit #166

merged 1 commit into from
Feb 16, 2023

Conversation

ByteCarlos
Copy link
Contributor

What has changed:

  • Schools checkbox now works correctly in user edition
  • Fixed the translation of the active column in the edit user index
  • The user rule is now being changed correctly revoking the previous one

Modified files:

  • AdminController.php (update user function)
  • Users.php (attribute labels function)

@ByteCarlos ByteCarlos temporarily deployed to QA February 16, 2023 13:48 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA February 16, 2023 13:48 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

ByteCarlos
ByteCarlos commented Feb 16, 2023
View reviewed changes
Copy link
Contributor Author

@ByteCarlos ByteCarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All possible tests have been done and all fixes have been applied.

@igorgoncalves igorgoncalves merged commit e1b73de into master Feb 16, 2023
igorgoncalves added a commit that referenced this pull request Feb 23, 2023
@ByteCarlos @igorgoncalves
fix: data table implementation in user edit module (#172)
d62ac6f 
* First commit

* fix: form fixes in user edit (#166)

* feature: User duplicate blocking via name and username (#167)

* fix: user duplicate lock

* refactor: code unused remove

* fix: now the render of the update function correctly renders the view following the design pattern

* fix: adding a empty DocumentAndAddress when not load (#170)

* fix: changing position do echo html on report (#171)

* fix: data table fixes

* fix: post request working in dev form

* fix: temporary css fixing user edit form breaks

* refactor: unintentionally modified code corrected for merge

* fix: unintentionally deleted code rewritten

---------

Co-authored-by: Igor Gonçalves <igor_goncalves@live.com>
@igorgoncalves igorgoncalves deleted the fix/form-fixes-in-user-edit branch December 6, 2023 22:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@igorgoncalves igorgoncalves Awaiting requested review from igorgoncalves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByteCarlos @igorgoncalves