Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: student restrictions change SQL query #218

Merged
merged 17 commits into from
Mar 24, 2023

Conversation

ByteCarlos
Copy link
Contributor

Change 1: Migrate student_identification data from food_restrictions column to others column in student_restrictions table

  • The student identification data from the food_restrictions column has been moved to the others column in the student_restrictions table. This was done to ensure better organization of the data and to facilitate the search for information on student dietary restrictions.

Change 2: SQL Query fix in special menus report controller

  • Fixed the Query SQL in the special menus report controller to ensure that information about students' dietary restrictions is displayed correctly in the report. The correction was needed because the previous Query was generating incorrect information.

Note: It is necessary to run the add_student_restrictions.sql SQL script located in app\migrations\3.9.13_add_student_restrictions\add_student_restrictions.sql for the changes to be made correctly.
Please review and approve this pull request.

@ByteCarlos ByteCarlos temporarily deployed to QA March 24, 2023 14:18 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA March 24, 2023 14:18 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ByteCarlos ByteCarlos changed the title fix: student restrictions fix: student restrictions change sql query Mar 24, 2023
@ByteCarlos ByteCarlos changed the title fix: student restrictions change sql query fix: student restrictions change SQL query Mar 24, 2023
@igorgoncalves igorgoncalves merged commit 3c5bfdb into dev Mar 24, 2023
@igorgoncalves igorgoncalves deleted the feature/student-restrictions branch December 6, 2023 22:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants