Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: corrections quarterly report #264

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

ByteCarlos
Copy link
Contributor

Description of fixes

  • Now the council minutes report shows a warning when there are no students enrolled in the class. This was implemented to help teachers and administrators easily identify when a class has no students enrolled and take appropriate action.
  • A treatment was added for when the date already comes from the database in the dd/mm/yyyy format. This was implemented to fix an issue with inconsistent date format that was affecting some reports. With this change, the date will always be consistently displayed and easy to read.
  • The styling of all quarterly reports has been fixed. This was done to ensure reports are easy to read and understand, no matter what device they are viewed on. The style is now consistent across all quarterly reports, making it easier for users to identify important information.

@ByteCarlos ByteCarlos temporarily deployed to QA April 23, 2023 20:10 — with GitHub Actions Inactive
@ByteCarlos ByteCarlos temporarily deployed to QA April 23, 2023 20:10 — with GitHub Actions Inactive
Copy link
Contributor Author

@ByteCarlos ByteCarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todas as alterações foram revisadas e testadas no banco teste de buzios/RJ.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
40.0% 40.0% Duplication

@ByteCarlos
Copy link
Contributor Author

IMPORTANTE

Ressalto que todas as migrations tem que ser rodadas no bancos de buzios para tudo funcionar corretamente, principalmente as que envolvem as tabelas de student_enrollment e teaching_matrix.

@igorgoncalves igorgoncalves merged commit 7666879 into dev Apr 24, 2023
@igorgoncalves igorgoncalves deleted the fix/corrections-quarterly-report branch December 6, 2023 22:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants