Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update CI/CD and Tests #164

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update CI/CD and Tests #164

merged 3 commits into from
Nov 21, 2024

Conversation

riley-harper
Copy link
Contributor

@riley-harper riley-harper commented Nov 21, 2024 •
edited
Loading

Closes #160.

This PR makes a few updates to the CI/CD and tests.

  • CI/CD now only runs on pushes or PRs to the main branch. This decreases the amount of CI/CD runs that we do, which should be nicer to the environment. It also fixes a bug where CI/CD runs ran twice on the last commit in each PR.
  • I've removed the custom "quickcheck" pytest marker in favor of using the built-in filtering. I added some more info to the developer docs with a link to the pytest docs on test filtering.
  • We no longer run flake8 in CI/CD, as it was proving to be more trouble than it was worth. Most IDEs will catch these errors that flake8 flags. You can still run flake8 manually if you install hlink with the dev extra.

@riley-harper
[#160] Only run CI/CD on pushes and PRs to main
53b0ad3 
This reduces the number of CI/CD runs, which is helpful because each run is
becoming more and more expensive (in terms of time and energy).
@riley-harper
[#160] Remove the custom pytest.mark.quickcheck
35a7810 
The built-in pytest filtering functionality has been more helpful than this
custom marker. I added some documentation to doc/developer.md which points to
the pytest docs for filtering.
@riley-harper
[#160] Remove flake8 from CI/CD
951ebd8
@riley-harper riley-harper merged commit 6199f6b into main Nov 21, 2024
3 checks passed
@riley-harper riley-harper deleted the ci_cd_updates branch November 21, 2024 19:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CI/CD and Tests
1 participant
@riley-harper