Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix html_embed exporter #1044

Merged
merged 2 commits into from
Aug 19, 2017
Merged

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Aug 12, 2017

Fixes issue #1041:
Correctly embed images already embedded in the notebook itself.

@gabyx
Copy link
Contributor

gabyx commented Aug 12, 2017

was the path already in the metadata?
I thought there is not path variable in the resource metadata :-)
if so, this is a cool fix :-) fixes my export button to

@juhasch
Copy link
Member Author

juhasch commented Aug 12, 2017

This works at when calling nbconvert from command line.
I don't have notebook 5.1 running, so this might not work with your extension. However, I would assume this is a bug in the notebook then.

@gabyx
Copy link
Contributor

gabyx commented Aug 12, 2017

ah, ok, hm..., so this merge will
make my extension not working before the notebook bug is not resolved...
maybe I have some time

@juhasch
Copy link
Member Author

juhasch commented Aug 12, 2017

Hmm, looks like the notebook calls from_notebook_node() and does not provide the path. In my eyes it should. This means I need to add a check in the exporter, and your problem with the extension is still not solved.

@gabyx
Copy link
Contributor

gabyx commented Aug 12, 2017

Created a pull request to fix that:
jupyter/notebook#2753

@juhasch juhasch merged commit a525f3a into ipython-contrib:master Aug 19, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants