Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make Travis happy again #1097

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Make Travis happy again #1097

merged 1 commit into from
Sep 18, 2017

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Sep 17, 2017

  • increase allowed line length (hard to achieve 80 characters with the long jupyter command lines)
  • change imports so isort is happy

@juhasch
Copy link
Member Author

juhasch commented Sep 17, 2017

@jcb91 Do you agree with allowing longer line lengths ?

@juhasch juhasch mentioned this pull request Sep 17, 2017
Merged
@jcb91
Copy link
Member

jcb91 commented Sep 18, 2017

@jcb91 Do you agree with allowing longer line lengths ?

Meh, I prefer 80 char, but yeah, it's not a big deal. I think I recall once seeing that IPython used 100-char lines, but I forget where I saw that (or even if I imagined it), so I'm happy to settle for 120.

@jcb91 jcb91 merged commit 9b79e71 into ipython-contrib:master Sep 18, 2017
@juhasch juhasch deleted the lint branch September 18, 2017 19:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhasch @jcb91