Undefined title_sidebar #1175
Merged
Undefined title_sidebar #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some "old" exported html files, with toc2 embedded, the `cfg.title_sidebar` is not defined; This tests for the cfg key and define it if necessary (Otherwise the sidebar title appears as "undefined")
|
This (along with all metadata values) should already have a default value in the newest version? Is that not working correctly? |
|
Yes, with current version and conversions, but already converted notebooks do not have all variables defined. See eg this example. Of course I can easily update my own files (I have a bunch of lectures in ipynb/html formats), but there can be some other floating in the web. |
|
Oh, I'm all for having defaults! I just thought that this (and similar issues) would be handled by 1972313, but it seems I forgot that the I've pushed a commit which should ensure defaults are set for all config values... |
|
Seems to work for the title :) |
|
Well done! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some "old" exported html files, with toc2 embedded, the
cfg.title_sidebaris not defined; This tests for the cfg key and define it if necessary (Otherwise the sidebar title appears as "undefined")