Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[toc2] Initialize toc2 button after cfg is loaded / fix #1249 #1250

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

jfbercher
Copy link
Member

@jfbercher jfbercher commented Feb 24, 2018

Tentative fix for #1249.
Initialize toc_button(cfg) only after cfg has been defined (perhaps not read yet (?), but defined). Otherwise, the handler in toc_button points to an undefined object.

also use local Jupyter variable rather than global
@jfbercher
Copy link
Member Author

Let's give a try to this

@jfbercher jfbercher merged commit f4cb633 into ipython-contrib:master Mar 19, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants