Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Freeze uses cell.metadata.editable to support 4.x and 5.x Jupyter notebooks. #968

Merged
merged 4 commits into from
Apr 22, 2017

Conversation

tnarik
Copy link
Contributor

@tnarik tnarik commented Apr 22, 2017

Freeze uses cell.metadata.editable instead of cell.metadata.run_control.read_only.
This version reads old format metadata and replaces it by new format metadata (for Freeze).

…ol.read_only.

This version reads old format metadata and replaces it by new format metadata (for Freeze).
@tnarik
Copy link
Contributor Author

tnarik commented Apr 22, 2017

New pull request for #940. Apologies if this makes things confusing, but it was easier and faster for me to just create a new branch and pull request.

also more aggressive removal of redundant metadata
@jcb91
Copy link
Member

jcb91 commented Apr 22, 2017

Sure, no problem, it's certainly simpler from scratch in this case! This looks mainly good, but I've a few changes to add that I'll PR to your fork

jcb91 and others added 2 commits April 22, 2017 12:08
mainly semicolons
[Freeze] alterations to 5.x update
@jcb91 jcb91 merged commit ca5b710 into ipython-contrib:master Apr 22, 2017
@jcb91
Copy link
Member

jcb91 commented Apr 22, 2017

Thanks @tnarik!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants