Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extract the Comm Python package #973

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou commented Aug 1, 2022

Currently working on a Python comm package on https://github.com/martinRenou/comm for now, but it should probably be moved in the IPython org
This PR relies on the new comm package https://github.com/ipython/comm

This has the benefit of being able to:

pyproject.toml Outdated Show resolved Hide resolved
@martinRenou martinRenou force-pushed the move_comm branch 2 times, most recently from f60a46f to 48524de Compare November 18, 2022 19:21
@martinRenou martinRenou marked this pull request as ready for review November 18, 2022 20:23
@martinRenou
Copy link
Contributor Author

I marked the PR as ready to review!

I might be wrong but the ipyparallel issue seems unrelated?

  =========================== short test summary info ============================
  ERROR  - DeprecationWarning: Jupyter is migrating its paths to use standard p...
  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
  =============================== 1 error in 0.90s ===============================

@blink1073
Copy link
Contributor

I might be wrong but the ipyparallel issue seems unrelated?

Correct

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6607b9d into ipython:main Nov 18, 2022
@blink1073
Copy link
Contributor

I'll cut a minor release with this change early next week.

@ccordoba12
Copy link
Member

@blink1073, is there full compatibility for projects that import the comm module from here? We do that in Spyder-kernels.

@blink1073
Copy link
Contributor

Yes, the equivalent classes are exported from the comm module.

@martinRenou martinRenou deleted the move_comm branch November 18, 2022 23:25
@maartenbreddels
Copy link
Contributor

This broke compatibility in Solara, since I was doing

Giving me:

>       self.comm_manager = CommManager(parent=self, kernel=self)
E       TypeError: __init__() got an unexpected keyword argument 'parent'

Not sure if this should be considered a public API (the constructor), if so, happy to open an issue.

maartenbreddels added a commit to widgetti/solara that referenced this pull request Nov 21, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Nov 21, 2022
@maartenbreddels
Copy link
Contributor

@martinRenou really nice to see this out this soon btw :) congrats

@blink1073
Copy link
Contributor

I think the cause is the same as #1026

blink1073 added a commit to blink1073/ipykernel that referenced this pull request Dec 7, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
maartenbreddels added a commit to widgetti/solara that referenced this pull request Dec 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants