Replace outdated convenience copy of Tcl with system provided one #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
olebole
force-pushed
the
update-tcl-api
branch
2 times, most recently
from
df3c9d9
to
8037b1f
Compare
This still requires a Tcl version 7, as version 8 has a number of incompatibilities.
Tcl8 is an incompatible update and requires a number of changes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy of Tcl that is included in the sources is ~30 years old (7.3) and should not be used anymore.
Specifically Linux distributions require to use the actual system provided versions instead of these old libs. However, Tcl changed (unsurprisingly) in an incompatible way in the last 30 years.
This PR removes the Tcl sources and replaces them with linking to the System Tcl. All incompatibilities are removed.
This is mainly stolen from the upcoming Debian package. As for compatibility, it should work with all Tcl8 versions.
On MacOS, there is Tcl 8.5 available.