Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: switch to NanoAOD input files for AGC CMS ttbar notebook #102

Merged
merged 16 commits into from
Apr 17, 2023
Merged

feat: switch to NanoAOD input files for AGC CMS ttbar notebook #102

merged 16 commits into from
Apr 17, 2023

Conversation

ekauffma
Copy link
Collaborator

@ekauffma ekauffma commented Feb 16, 2023 •
edited by alexander-held
Loading

  • Branch and tree names were altered accordingly,
  • Different branches are selected for the only_do_IO method in the coffea processor
  • Table with file sizes is changed to reflect the new files

resolves #63

@alexander-held alexander-held self-requested a review February 16, 2023 12:43
alexander-held
alexander-held reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for preparing this, the jupytext use is already paying off for this PR alone. Nice to see that the changes required overall really aren't all that many!

@alexander-held alexander-held mentioned this pull request Apr 2, 2023
Closed
6 tasks
@alexander-held alexander-held changed the title Changed AGC CMS ttbar notebook to take nanoAOD as input feat: switch to NanoAOD input files for AGC CMS ttbar notebook Apr 13, 2023
@alexander-held
Copy link
Member

They are pre-converted from miniAOD files into ntuple format, similar to nanoAODs.

We need to change that line into something like

They were originally published in miniAOD format.
For the purpose of this demonstration these files were pre-converted into nanoAOD format and the nanoAOD files are used as input here.

alexander-held
alexander-held approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you!

@alexander-held alexander-held merged commit b040821 into iris-hep:main Apr 17, 2023
@alexander-held alexander-held mentioned this pull request Dec 19, 2023
Open
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexander-held alexander-held alexander-held approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to nanoAOD inputs for CMS Open Data pipeline demonstration
2 participants
@ekauffma @alexander-held