adds ledger flag to 'wallet:multisig:participant' #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
force-pushed
the
feat/hughy/participant-cmd-ledger
branch
from
e4b211e to
69c79cc
Compare
hughy
changed the title
supports reading identity from ledger and displaying on CLI
hughy
force-pushed
the
feat/hughy/participant-cmd-ledger
branch
from
69c79cc to
dd50e47
Compare
NullSoldier
approved these changes
Jan 24, 2025
NullSoldier
reviewed
Jan 24, 2025
| @@ -29,6 +35,19 @@ export class MultisigIdentity extends IronfishCommand { | |||
|
|
|||
| this.log('Identity:') | |||
| this.log(response.content.identity) | |||
| } else if (flags.ledger) { | |||
There was a problem hiding this comment.
I think we can move the wallet decryption check into the flags.name branch since we don't use the wallet in the ledger flow.
|
This looks good. I tested it manually. The only comment is around the encryption check. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
supports reading identity from ledger and displaying on CLI
Testing Plan
ironfish wallet:multisig:participant --ledgerDocumentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.