Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

reads identity from Ledger in DKG round3 #5718

Merged
merged 1 commit into from
Feb 13, 2025
Merged

reads identity from Ledger in DKG round3 #5718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ironfish-cli/src/commands/wallet/multisig/dkg/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,14 +447,18 @@ export class DkgCreateCommand extends IronfishCommand {
ledger: LedgerMultiSigner,
client: RpcClient,
accountName: string,
participantName: string,
round1PublicPackagesStr: string[],
round2PublicPackagesStr: string[],
round2SecretPackage: string,
accountCreatedAt?: number,
): Promise<void> {
const identityResponse = await client.wallet.multisig.getIdentity({ name: participantName })
const identity = identityResponse.content.identity
const identity = (
await ui.ledger({
ledger,
message: 'Getting Ledger Identity',
action: () => ledger.dkgGetIdentity(0),
})
).toString('hex')

// Sort packages by identity
const round1PublicPackages = round1PublicPackagesStr
Expand Down Expand Up @@ -563,7 +567,6 @@ export class DkgCreateCommand extends IronfishCommand {
ledger,
client,
accountName,
participantName,
round1PublicPackages,
round2PublicPackages,
round2Result.secretPackage,
Expand Down
9 changes: 7 additions & 2 deletions ironfish-cli/src/commands/wallet/multisig/dkg/round3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,13 @@ export class DkgRound3Command extends IronfishCommand {
): Promise<void> {
const ledger = new LedgerMultiSigner()

const identityResponse = await client.wallet.multisig.getIdentity({ name: participantName })
const identity = identityResponse.content.identity
const identity = (
await ui.ledger({
ledger,
message: 'Getting Ledger Identity',
action: () => ledger.dkgGetIdentity(0),
})
).toString('hex')

// Sort packages by identity
const round1PublicPackages = round1PublicPackagesStr
Expand Down