Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix route update #295

Merged
merged 6 commits into from
Nov 16, 2016
Merged

Fix route update #295

merged 6 commits into from
Nov 16, 2016

Conversation

pedronasser
Copy link
Contributor

@pedronasser pedronasser commented Nov 15, 2016

  • Added EnsureImage to route update

Relates to #288

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2016

CLA assistant check
All committers have signed the CLA.

@treeder
Copy link
Contributor

treeder commented Nov 16, 2016

@ccirello can you review

@ucirello
Copy link
Contributor

I am testing it...

@ucirello
Copy link
Contributor

It might have fixed something, but definitely it did not help with #288

@ucirello
Copy link
Contributor

This did not help with #288 - but I think I see the point of this change. In the end, this change would be necessary to ensure that route updates work. So partial route updates, ie the ones that are not changing the image, still go through.

@pedronasser pedronasser merged commit 7593480 into master Nov 16, 2016
@pedronasser pedronasser deleted the fix-route-update branch November 16, 2016 21:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants