fn: improve UX and publish/deploy command #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucirello
changed the title
ucirello
changed the title
ucirello
force-pushed
the
fn-publish
branch
3 times, most recently
from
9bf4ce9 to
093873e
Compare
|
@treeder @pedronasser @seiflotfy I have extensively checked and updated the documentation on this change. Please review, critique and merge if OK. |
treeder
suggested changes
Dec 1, 2016
| # Create a route to this function on IronFunctions | ||
| fn routes create myapp /hello | ||
| fn deploy myapp |
There was a problem hiding this comment.
I thought we were discussing that deploy would be more of a bulk operation only, for when you setup an entire app structure? What path would be used here?
There was a problem hiding this comment.
You're right. fixing it.
treeder
reviewed
Dec 1, 2016
| # Create a route to this function on IronFunctions | ||
| fn routes create myapp /hello | ||
| fn deploy myapp |
There was a problem hiding this comment.
This should still be push and routes create, not deploy.
| # Create a route to this function on IronFunctions | ||
| fn routes create slackbot /guppy | ||
| fn deploy slackbot |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
Partially addresses #364