Skip to content

Fix win32 test failure #303

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

erikkemperman
Copy link
Contributor

The test in eperm-stat.js fails on Appveyor because the fixtures don't include symlinks. This PR remedies that.

@raygervais
Copy link

With this fix, I believe many of the PRs of recent will pass the tests now. Hopefully you get merged sooner than later.

@erikkemperman
Copy link
Contributor Author

@raygervais All due respect to the maintainer, but it looks like he doesn't get around to handling issues/PRs very often. Kind of troubling, if you think about the very many packages depending on this.

@jdalton
Copy link

jdalton commented Aug 17, 2018

@isaacs As part of my follow-up from npm/node-semver#244 this PR would allow unskipping glob in CitGM for Windows (restores passing appveyor too).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants