Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove redundant images #122

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Remove redundant images #122

merged 3 commits into from
Jul 15, 2022

Conversation

programming-wolf
Copy link
Collaborator

  • Remove redundant logo
  • Remove text that is not executed anymore

The images for PDF files are handled by the pdf theme. This seems to
be a remnant of times before we had a separate pdf theme.
@aheusingfeld
Copy link
Member

@programming-wolf did you see my comments in #120?

@programming-wolf
Copy link
Collaborator Author

Yes, and I replied to them.

Copy link
Member

@aheusingfeld aheusingfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea as an intermediate step before moving the JPG to the html-theme

@programming-wolf
Copy link
Collaborator Author

Thing is, the "theme" is only css, the image would have to be placed by the original ADOC file, not the theme.

@programming-wolf programming-wolf merged commit 2ebfd2a into main Jul 15, 2022
@programming-wolf programming-wolf deleted the 120-remove-redundant-images branch November 4, 2022 13:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants