Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

corrected pairing in SSD head of pointpillars #602

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

zhongyidu
Copy link
Contributor

@zhongyidu zhongyidu commented Jun 17, 2023

Accordiing to the PointPillars paper, "A positive match is either the highest with a ground truth box, or above the positive match threshold". While the latter point is implemented correctly, there's a minor mistake in the implementation of the first point. The original code only updates the bool array pos_idx without changing the matched target to the correct ground truth index. This could lead to ground truth box without a valid match in the end.

When I corrected the SSD matching, I also referred to this implementation of SSD: https://github.com/amdegroot/ssd.pytorch/blob/5b0b77faa955c1917b0c710d770739ba8fbff9b7/layers/box_utils.py#L106


This change is Reviewable

Copy link
Collaborator

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @zhongyidu)

Copy link
Contributor Author

@zhongyidu zhongyidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zhongyidu)

@benjaminum benjaminum merged commit fb87da2 into isl-org:dev Oct 9, 2023
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants