Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add PointCloud Boundary Detection #5457

Merged
merged 8 commits into from
Aug 24, 2022
Merged

Add PointCloud Boundary Detection #5457

merged 8 commits into from
Aug 24, 2022

Conversation

yuecideng
Copy link
Collaborator

@yuecideng yuecideng commented Aug 19, 2022

This PR introduces the boundary detection algorithm, which is inspired by PCL boundary estimation. I think it would be useful for some cases such as registration and feature matching (compute descriptor only for boundary points).

The demo as below:

import open3d as o3d

ply_point_cloud = o3d.data.DemoCropPointCloud()
pcd = o3d.t.io.read_point_cloud(ply_point_cloud.point_cloud_path)
boundarys, mask = pcd.compute_boundary_points(0.02, 30)
boundarys.paint_uniform_color([1.0, 0.0, 0.0])
o3d.visualization.draw([pcd, boundarys])

The expected results:
image


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Aug 19, 2022

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Collaborator

@yxlao yxlao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @reyanshsolis and @ssheorey)

@yxlao
Copy link
Collaborator

yxlao commented Aug 24, 2022

LGTM, I pushed a few minor changes.

@yxlao yxlao merged commit 267e60c into master Aug 24, 2022
@yxlao yxlao deleted the yueci/boundary-detection branch August 24, 2022 10:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants