Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed ProgressBar scrolling behaviour #6175

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

cansik
Copy link
Contributor

@cansik cansik commented May 25, 2023

As mentioned in #6174 the ProgressBar ist not scrolling as expected. This subtracts the necessary ImGui::GetScrollY() to the y coordinate.

Type

Motivation and Context

Otherwise the ProgressBar is not usable within ScrollableVert.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented May 25, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@cansik cansik force-pushed the fix-ui-scrolling-progress-bar branch from 8ae0bfe to c4e5f00 Compare May 25, 2023 19:38
@ssheorey ssheorey requested a review from errissa June 1, 2023 17:38
@cansik
Copy link
Contributor Author

cansik commented Aug 7, 2023

@ssheorey Thanks for looking into the PR, if something is missing, please tell me. Otherwise I would be happy if you could merge this and #6178 before the next release of Open3D. These two bugs are really breaking any serious GUI (even the official Open3D viewer does not work on MacOS).

@reyanshsolis
Copy link
Collaborator

@cansik Thanks for your valuable contribution. Is it possible for you to share a before-after screenshot/video for this PR ?

Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cansik)

@errissa errissa merged commit ce442ea into isl-org:master Oct 6, 2023
37 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressBar widget is not scrolling within ScrollableVert
3 participants