Skip to content

feat: add ability to remove whole deleted option #329

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Edmilson-C
Copy link

When deleting an option, if input is multiple, delete the whole option, instead of deleted letter by letter

@isneezy
Copy link
Owner

isneezy commented Feb 27, 2023

Hi @Edmilson-C, thank you for your contribution, could you please make this behavior optional (opt-in)?
This way we wouldn't break the software from others users of this component.

@isneezy isneezy changed the title Remove whole deleted option feat: add ability to remove whole deleted option Feb 27, 2023
@Edmilson-C
Copy link
Author

Hello @isneezy, I did the change that you asked.

@isneezy
Copy link
Owner

isneezy commented Apr 20, 2023

That's Awesome, one more thing. Please update the documentation. Specifically this file docs/api/props.md

@Edmilson-C
Copy link
Author

@isneezy Hello, it's done

@Edmilson-C
Copy link
Author

Hi @isneezy, have you seen the change yet?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants