Add Accordion and AccordionItem Components
#27
Conversation
- Remove `HeadingSize` - Add `AccordionHeader` private component - Add `AccordionCollapse` private component - Change String properties to AttrValue - Added `stay_open` property to `Accordion` - Added `flush` property to `Accordion`
|
Added the version bump and all of the additional functionality(other than styling classes) for Included doc comments for using the There may still be things to do for a fully fledged implementation but this gets most of the basics implemented. A noteable design decision was made when determining which components and properties were public/private. The thought process here is that ideally we want to abstract away the inner workings of the underlying bootstrap components otherwise users would just write it themselves. So assigning id's to children and attaching them to their parents was done programatically. Additionally users can't create These decisions may be a hindrance in the future and should then be re-evaluated at that time by future users/editors. |
|
Looks good, thank you for your contribution! I especially appreciate that accessibility recommendations from Bootstrap have been implemented ( I've added an example to our I'm ready to merge this code; it's an improvement. Please confirm re:
|
yup forgot to remove that line. I’m also happy to merge it with the updated commit |
Using functional components, but if you'd like me to refactor with normal components let me know. Also no doc comments as it's not finalized and doesn't include all Accordion functionality. Want to make sure it looks good before finalizing.
Please don't merge as is.
If there's any changes you want made let me know. If not I'll finalize in the same style as it is now with a proper commit message, doc comments, and complete functionality.