Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check for all older versions of html5lib instead of just 0.95 #168

Closed
jethrogb opened this issue Feb 20, 2015 · 6 comments
Closed

Check for all older versions of html5lib instead of just 0.95 #168

jethrogb opened this issue Feb 20, 2015 · 6 comments

Comments

@jethrogb
Copy link

In https://github.com/posativ/isso/blob/master/isso/utils/html.py#L48 there's a check for html5lib being version 0.95. That should be being <=0.95.

posativ added a commit that referenced this issue Feb 24, 2015
@posativ posativ closed this as completed Feb 24, 2015
@jethrogb
Copy link
Author

I don't understand this fix. You just increased the dependency requirements for no reason, while the alternate code path works perfectly fine for older versions of html5lib.

@posativ
Copy link
Collaborator

posativ commented Feb 24, 2015

I can confirm that html5lib 0.95 (or higher) works. For example, 0.95 to 0.999 broke compatibility, so I don't see a reason to support versions that are not tested (by the autor) and quite old.

@jethrogb
Copy link
Author

0.90 is in Debian Squeeze LTS and Ubuntu 12.04 LTS

@posativ
Copy link
Collaborator

posativ commented Feb 24, 2015

Update or use a virtualenv.

@posativ posativ reopened this Feb 24, 2015
@posativ
Copy link
Collaborator

posativ commented Feb 25, 2015

I've added support for older html5lib (expect a maintenance release soon (tm)). If it breaks somewhere else, I will drop support for 0.95 entirely. I don't have the time to maintain compatibility with LTS version of certain distributions, when you can use virtualenv.

@posativ posativ closed this as completed Feb 25, 2015
@jethrogb
Copy link
Author

Thanks :)

posativ added a commit that referenced this issue Mar 4, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants