override thread discovery with custom data-attributes

[posativ]

No description provided.

[posativ]

Broken when using the same comment thread on multiple URLs.

[Zimmi48]

Hi,

I have two problems:

• the same page is accessible via example.tld and example.tld/index but Isso thinks the two pages are different because the URL is not the same
• if, in the future, I move a page URL, I am afraid I would lose the comments.

Making this feature work again would solve these two problems I think.
Is there a lot to do about it? If you tell me where to look and what does not work I may cast a look and see if I can fix that...

Thanks!

[posativ]

The issue is basically a missing one-to-many (id to urls, it is id -> url currently) relation in the database. It requires some work (you need to do the migrations, too).

[dashohoxha]

This is a big problem for me, because I want to use comments in a mobile app, where url almost never changes, but the content changes (through ajax). So, I need to be able to reference the comments by id, not by url.

Without knowing the structure of the DB and without looking at the code, I would suggest to just get rid of URLs everywhere. We don't need them, we need just IDs in order to identify comment threads. By ID I mean a unique string, not a number. In special cases it can be set to be the url itself, in special cases it can be a number (converted to string), but let the website decide what the ID of the comment thread should be.

[gllmhyt]

It was working with 0.9.10, but since 0.10.1 it seems not, too bad!

[posativ]

This issue is still open, what do you mean exactly?

[blatinier]

This should be closed since you merged #252 right?

[rawsh]

Can this be used now? AMP pages are a usecase

[ix5]

Is this still current?

[ix5]

Should be fixed by #252