-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Counter problem #448
Labels
bug
client
(Javascript) client code and CSS
needs-contributor
Someone needs to implement this. Help wanted!
Milestone
Comments
ix5
added
bug
client
(Javascript) client code and CSS
needs-contributor
Someone needs to implement this. Help wanted!
labels
Dec 27, 2021
3 tasks
pkvach
added a commit
to pkvach/isso
that referenced
this issue
Mar 7, 2024
Changes to properly count hidden comments when calculating the total number of comments. Fixes isso-comments#448
3 tasks
pkvach
added a commit
to pkvach/isso
that referenced
this issue
Mar 20, 2024
Changes to properly count hidden comments when calculating the total number of comments. Fixes isso-comments#448
pkvach
added a commit
to pkvach/isso
that referenced
this issue
Mar 30, 2024
Changes to properly count hidden comments when calculating the total number of comments. Fixes isso-comments#448
pkvach
added a commit
to pkvach/isso
that referenced
this issue
Apr 14, 2024
Changes to properly count hidden comments when calculating the total number of comments. Fixes isso-comments#448
pkvach
added a commit
to pkvach/isso
that referenced
this issue
Apr 14, 2024
Changes to properly count hidden comments when calculating the total number of comments. Fixes isso-comments#448
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
bug
client
(Javascript) client code and CSS
needs-contributor
Someone needs to implement this. Help wanted!
Consider a thread with nested comments, 25 comments in total, 13 of them are top-level. When counter is placed with the code:
it produces
25
all the time. However, the counter just after the<section id="isso-thread">
produces different number depending on the amount of comments shown after page load. E.g., whendata-isso-max-comments-top="10"
setting is applied and only 10 top-level + 6 nested comments are shown, this counter gives 19, because 3 top-level + 6 nested are hidden (10+6+3=19
).<a href="#" class="load_hidden"></a>
tells that only 3 comments are hidden, whereas 3 top-level and 6 nested comments are hidden. Is it an intended behavior? It is also possible that I messed something up — I used to have nesting off, but recently turned it on and modified manually database file by setting parents for some comments.PS if only nested comments are hidden, both counters show total number of comments.
The text was updated successfully, but these errors were encountered: