Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Counter problem #448

Closed
pozitron57 opened this issue May 27, 2018 · 0 comments · Fixed by #997
Closed

Counter problem #448

pozitron57 opened this issue May 27, 2018 · 0 comments · Fixed by #997
Labels
bug client (Javascript) client code and CSS needs-contributor Someone needs to implement this. Help wanted!
Milestone

Comments

@pozitron57
Copy link
Contributor

pozitron57 commented May 27, 2018

Consider a thread with nested comments, 25 comments in total, 13 of them are top-level. When counter is placed with the code:

<a href="/blog/post/#isso-thread">Comments</a>,

it produces 25 all the time. However, the counter just after the <section id="isso-thread"> produces different number depending on the amount of comments shown after page load. E.g., when data-isso-max-comments-top="10" setting is applied and only 10 top-level + 6 nested comments are shown, this counter gives 19, because 3 top-level + 6 nested are hidden (10+6+3=19).

<a href="#" class="load_hidden"></a> tells that only 3 comments are hidden, whereas 3 top-level and 6 nested comments are hidden. Is it an intended behavior? It is also possible that I messed something up — I used to have nesting off, but recently turned it on and modified manually database file by setting parents for some comments.

PS if only nested comments are hidden, both counters show total number of comments.

@ix5 ix5 added bug client (Javascript) client code and CSS needs-contributor Someone needs to implement this. Help wanted! labels Dec 27, 2021
@ix5 ix5 added this to the backburner milestone May 14, 2022
@BBaoVanC BBaoVanC moved this to Todo in Isso Todo May 14, 2022
@BBaoVanC BBaoVanC moved this from Todo to Backlog in Isso Todo May 14, 2022
pkvach added a commit to pkvach/isso that referenced this issue Mar 7, 2024
Changes to properly count hidden comments when calculating the total number of comments.

Fixes isso-comments#448
pkvach added a commit to pkvach/isso that referenced this issue Mar 20, 2024
Changes to properly count hidden comments when calculating the total number of comments.

Fixes isso-comments#448
pkvach added a commit to pkvach/isso that referenced this issue Mar 30, 2024
Changes to properly count hidden comments when calculating the total number of comments.

Fixes isso-comments#448
pkvach added a commit to pkvach/isso that referenced this issue Apr 14, 2024
Changes to properly count hidden comments when calculating the total number of comments.

Fixes isso-comments#448
pkvach added a commit to pkvach/isso that referenced this issue Apr 14, 2024
Changes to properly count hidden comments when calculating the total number of comments.

Fixes isso-comments#448
@ix5 ix5 closed this as completed in #997 Apr 23, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Isso Todo Apr 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug client (Javascript) client code and CSS needs-contributor Someone needs to implement this. Help wanted!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants