Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add configuration to make email a required field #199

Merged
merged 2 commits into from
Nov 8, 2015

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Aug 25, 2015

This patch adds a parameter to make requiring an email address configurable.

Could probably be improved by:

  • write tests
  • using HTML5 form validation
  • not using a nasty regex substitute to remove (required) from the placeholder (or internationalised equivalent)

@NickHu NickHu force-pushed the require-email branch 3 times, most recently from 46a47c6 to cd54cf1 Compare August 25, 2015 14:53
@posativ posativ merged commit b9ce411 into isso-comments:master Nov 8, 2015
@posativ
Copy link
Collaborator

posativ commented Nov 8, 2015

Thanks for the contribution. Email verification is not easy and usually requires a validation email being sent. I am okay with the current implementation though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants