[client] Fix avatar sizing on Chrome & Safari #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, on Chrome and Safari (but not Firefox), the
svg
inside.isso-avatar
has a size of 0 by 0 pixels. Not sure why it worked on Firefox, but this makes sense because svg's have no native size, and since there was no minimum size specified, it defaulted to 0.Instead of just setting
width
to48px
, I set it to100%
and leftmax-width
set to48px
. It should be better practice this way.I am wondering if setting
height
is a good idea, since it seems to have no effect. I kept it in just because it's clearer.Before (demo on Chromium)
After