[client][ci] Tests: Add screenshot testing #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
added
client
ix5
force-pushed
the
js-jest-screenshots
branch
3 times, most recently
from
e9938cc to
0caae62
Compare
Needed for writing screenshots
> The nocopy modifier is for when you are creating a volume > and data already exists in the container's path, you can > specify if you want that data copied when the volume is > created. https://stackoverflow.com/a/38288382
These tests generate actual `.png` screenshots, saved to the `isso/js/tests/integration/screenshots/` folder. Utilization of those screenshots will follow in a later commit.
In addition to the unit tests (which rely on manual insertion of elements), test the default `embed.dev.js` behavior and ensure the generated output matches.
ix5
force-pushed
the
js-jest-screenshots
branch
4 times, most recently
from
50edbab to
fcaccad
Compare
Relies on imagemagick to strip out metadata and only compare the image contents (via known hashes) Screenshots generated by running `npm run test-integration` in docker testbed. Screenshot hashes generated by running `compare-hashes.sh` in docker testbed.
ix5
force-pushed
the
js-jest-screenshots
branch
2 times, most recently
from
afab9de to
3936165
Compare
ix5
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
js: test/integration: Add screenshot tests
These tests generate actual
.pngscreenshots, saved to theisso/js/tests/integration/screenshots/folder.js: test/integration: Add Jest snapshots for whole widget
In addition to the unit tests (which rely on manual insertion of elements), test the default
embed.dev.jsbehavior and ensure the generated output matches.js: test/integration: Add screenshot comparison script
Relies on imagemagick to strip out metadata and only compare the image contents (via known hashes)
Why is this necessary?
Better test coverage and checking if CSS changes do unexpected things.